Skip to content

cs_network_offering: add tags support #82

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Aug 15, 2021

Conversation

resmo
Copy link
Member

@resmo resmo commented Aug 11, 2021

closes #77

/cc @div8cn you may want to give it a shot.

@resmo resmo force-pushed the feature/cs_network_offering_tags branch from e1caf60 to 8bb4386 Compare August 11, 2021 13:25
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #82 (ede119c) into master (f83d456) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   84.23%   84.25%   +0.01%     
==========================================
  Files          56       56              
  Lines        5590     5597       +7     
  Branches     1256     1255       -1     
==========================================
+ Hits         4709     4716       +7     
+ Misses        446      445       -1     
- Partials      435      436       +1     
Impacted Files Coverage Δ
plugins/module_utils/cloudstack.py 71.82% <ø> (-0.13%) ⬇️
plugins/modules/cs_network_offering.py 88.17% <100.00%> (+1.26%) ⬆️
plugins/modules/cs_disk_offering.py 94.28% <0.00%> (-2.86%) ⬇️
plugins/modules/cs_service_offering.py 93.24% <0.00%> (-1.36%) ⬇️
plugins/modules/cs_instance.py 71.52% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83d456...ede119c. Read the comment docs.

@resmo resmo force-pushed the feature/cs_network_offering_tags branch 4 times, most recently from da3facc to cd08001 Compare August 14, 2021 15:32
@resmo resmo force-pushed the feature/cs_network_offering_tags branch from cd08001 to 3518f0f Compare August 14, 2021 15:37
@resmo resmo added ready and removed changelog labels Aug 15, 2021
@resmo
Copy link
Member Author

resmo commented Aug 15, 2021

Test fails if adding tags to the tests with

Unable to find physical network in zone id=3

However, if i only run this test with tags isolated, test passes. I assume the failing is related to another test. That is why I will merge it in as is nevertheless.

@resmo resmo merged commit d16c15f into master Aug 15, 2021
@resmo resmo deleted the feature/cs_network_offering_tags branch August 15, 2021 07:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cs_network_offering does not support tags
1 participant