Skip to content

Re-organize the project structure, change the name and clean the dependencies. #362

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Aug 8, 2021

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented Aug 5, 2021

Pretty much what's said in the title, this PR is an attempt at cleaning up the project structure a little bit, and doing away with the indirect dependencies in go.mod.

@buchdag
Copy link
Member Author

buchdag commented Aug 5, 2021

@tkw1536 is there a point to keep go version to 1.11 in go.mod ?

@tkw1536
Copy link
Contributor

tkw1536 commented Aug 5, 2021

Only if we want to allow compilation under old go versions.

@buchdag
Copy link
Member Author

buchdag commented Aug 5, 2021

To be honest I have absolutely no idea if people are still compiling docker-gen on out of date versions of go.

On the other hand sticking to 1.11 prevents us from using more recent features of the language:

For packages within the module, the compiler rejects use of language features introduced after the version specified by the go directive.

If this is project is to be actively maintained and given the fact that we release pre built binaries, I think we should rather stick to the current version of go.

@buchdag buchdag merged commit 2d078b1 into main Aug 8, 2021
@buchdag buchdag deleted the restructure branch August 8, 2021 09:42
@buchdag buchdag mentioned this pull request Sep 9, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants