Fix functions that take a field path

[rhansen]

• Fix deepGet to automatically dereference pointers when walking the field path.
• Support accessing map entries with an empty string key.
• Extend field paths to support slice/array element access.

[buchdag]

Interesting, do you have something specific in mind made possible by those improvements ?

[rhansen]

Yes, I will need it for my proposed fix for nginx-proxy/nginx-proxy#1504.

[rhansen]

Doh, I didn't realizing that a simple rebase was enough to dismiss a review. And resetting it back doesn't restore the review. 🙁

[buchdag]

Doh, I didn't realizing that a simple rebase was enough to dismiss a review. And resetting it back doesn't restore the review. 🙁

Yeah, since a rebase changes the commits hashes, GitHub view them as different commits and marks the previous review(s) as stale. Out of curiosity, did it automatically re-request a review from me or did you have to do it manually ?

[rhansen]

Yeah, since a rebase changes the commits hashes, GitHub view them as different commits and marks the previous review(s) as stale.

I was hoping it was smart enough to realize the commits were a rebase (that each commit's tree hash was the same as if I had chosen "rebase and merge"}, or, if not, that I could undo the rebase. Sadly no on both counts.

Out of curiosity, did it automatically re-request a review from me or did you have to do it manually ?

I re-requested the review manually.