Skip to content

Filter containers to notify #549

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 3 commits into from

Conversation

tarasov65536
Copy link
Contributor

This PR gives ability to specify set of filters to containers query when new generated file arrived.

It is kinda similar to #311 but with better implementation from architectural point of view.

It introduces new command line argument -notify-filter that adds filter in list of filters to query containers that should be notified when generated file changed. Argument format as in docker api

For example:

docker-gen -notify-filter name=foo -notify-filter label=bar=baz ...

adds two filters to containers query.

Signal code still defined by argument -notify-signal.

@josegonzalez
Copy link
Contributor

This probably needs a test in order to get merged.

@tarasov65536
Copy link
Contributor Author

@josegonzalez, what kind of test it needs? Can't find anything similar.

@buchdag
Copy link
Member

buchdag commented May 16, 2024

Superseded by #619

@buchdag buchdag closed this May 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants