feat: filter containers seen by docker-gen #623
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buchdag
commented
Mar 23, 2025
| flag.BoolVar(¬ifyOutput, "notify-output", false, "log the output(stdout/stderr) of notify command") | ||
| "only include containers with published ports (implies -only-exposed). Bypassed when providing a container published filter (-container-filter published=foo).") | ||
| flag.BoolVar(&includeStopped, "include-stopped", false, | ||
| "include stopped containers. Bypassed by when providing a container status filter (-container-filter status=foo).") |
There was a problem hiding this comment.
Suggested change
| "include stopped containers. Bypassed by when providing a container status filter (-container-filter status=foo).") | |
| "include stopped containers. Bypassed when providing a container status filter (-container-filter status=foo).") |
buchdag
commented
Mar 23, 2025
| -include-stopped | ||
| include stopped containers | ||
| only include containers with published ports (implies -only-exposed). | ||
| Bypassed by when providing a container published filter (-container-filter published=foo). |
There was a problem hiding this comment.
Suggested change
| Bypassed by when providing a container published filter (-container-filter published=foo). | |
| Bypassed when providing a container published filter (-container-filter published=foo). |
buchdag
commented
Mar 23, 2025
| -notify-signal signal | ||
| signal to send to the -notify-container and -notify-filter. -1 to call docker restart. Defaults to 1 aka. HUP. | ||
| All available signals available on the dockerclient | ||
| https://github.com/fsouza/go-dockerclient/blob/main/signal.go | ||
| -only-exposed | ||
| only include containers with exposed ports | ||
| only include containers with exposed ports. | ||
| Bypassed by when using the exposed filter with (-container-filter exposed=foo). |
There was a problem hiding this comment.
Suggested change
| Bypassed by when using the exposed filter with (-container-filter exposed=foo). | |
| Bypassed when using the exposed filter with (-container-filter exposed=foo). |
buchdag
commented
Mar 23, 2025
| -endpoint string | ||
| docker api endpoint (tcp|unix://..). Default unix:///var/run/docker.sock | ||
| -include-stopped | ||
| include stopped containers. | ||
| Bypassed by when providing a container status filter (-container-filter status=foo). |
There was a problem hiding this comment.
Suggested change
| Bypassed by when providing a container status filter (-container-filter status=foo). | |
| Bypassed when providing a container status filter (-container-filter status=foo). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add the
-container-filteroption to filter the containers that docker-gen will see.The option work pretty much like
-notify-filterand can be used multiple times to combine filters with AND.This:
will result in docker-gen only seeing running container that possess the label
com.github.nginx-proxy.nginx.Closes #276
Unfortunately Docker filter options for containers does not provide negative filtering, so #117, #210, and #252 won't be entirely fixed by this.
Thanks @tarasov65536 for the inspiration.