-
Notifications
You must be signed in to change notification settings - Fork 94
Epic 472 port nginx one labs #681
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
content/nginx-one/workshops/lab2/run-workshop-components-with-docker.md
Outdated
Show resolved
Hide resolved
content/nginx-one/workshops/lab3/explore-nginx-one-console-and-features.md
Outdated
Show resolved
Hide resolved
content/nginx-one/workshops/lab3/explore-nginx-one-console-and-features.md
Outdated
Show resolved
Hide resolved
static/workshops/nginx-one/lab2/nginx-oss/etc/nginx/conf.d/stub_status.conf
Outdated
Show resolved
Hide resolved
static/workshops/nginx-one/lab2/nginx-oss/etc/nginx/conf.d/tls-cars.example.com.conf
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,176 @@ | |||
Apache License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about Apache License here, perhaps it should be clarified with SMEs:
- our license for docs is 2-clause BSD license
- we never published any licenses before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjang -- Thoughts? I think you suggested I include this license when we first looked at the workshops; however, as Yar notes, the product docs don't have this kind of license.
* Ported lab 5
…entation into epic-472-port-nginx-one-labs
edits from tech review Co-authored-by: yar <y82@users.noreply.github.com>
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Give a brief overview of the problem or feature being addressed.
Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.
Testing: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩