Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add auth_jwt_claim_set in nginx plus virtualserver template #7205

Merged
merged 8 commits into from
Jan 28, 2025

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Jan 23, 2025

Proposed changes

This PR is the first in a series to implement the tiered rate-limits based on JWT claims feature. It updates the VirtualServer nginx plus templates to allow setting the auth_jwt_claim_set directive. It defines the AuthJwtClaimSet struct to contain the directive values.

Future PR's will drive the content to populate these data structures.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.71%. Comparing base (65b2d52) to head (acf2971).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7205      +/-   ##
==========================================
- Coverage   52.72%   52.71%   -0.01%     
==========================================
  Files          89       89              
  Lines       20843    20843              
==========================================
- Hits        10989    10987       -2     
  Misses       9396     9396              
- Partials      458      460       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 force-pushed the feat/rate-limit-jwt-claim-template branch from 39a4d33 to 0e21880 Compare January 27, 2025 10:33
@pdabelf5 pdabelf5 marked this pull request as ready for review January 27, 2025 10:35
@pdabelf5 pdabelf5 requested a review from a team as a code owner January 27, 2025 10:35
@haywoodsh haywoodsh linked an issue Jan 27, 2025 that may be closed by this pull request
@pdabelf5 pdabelf5 enabled auto-merge (squash) January 28, 2025 15:01
@pdabelf5 pdabelf5 merged commit ba0b287 into main Jan 28, 2025
74 checks passed
@pdabelf5 pdabelf5 deleted the feat/rate-limit-jwt-claim-template branch January 28, 2025 15:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Implement template code to set auth_jwt_claim_set directives
5 participants