Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add central event reasons to the log package #7215

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 24, 2025

Proposed changes

Make Event reasons available in the log package

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner January 24, 2025 18:04
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 26.76056% with 104 lines in your changes missing coverage. Please review.

Project coverage is 52.70%. Comparing base (65b2d52) to head (49b340e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/controller.go 0.00% 41 Missing ⚠️
internal/configs/configmaps.go 20.93% 34 Missing ⚠️
internal/externaldns/sync.go 25.00% 6 Missing ⚠️
internal/k8s/transport_server.go 0.00% 6 Missing ⚠️
internal/k8s/appprotect_dos.go 0.00% 4 Missing ⚠️
internal/certmanager/sync.go 57.14% 3 Missing ⚠️
internal/k8s/global_configuration.go 0.00% 3 Missing ⚠️
internal/k8s/appprotect_waf.go 0.00% 2 Missing ⚠️
internal/k8s/policy.go 0.00% 2 Missing ⚠️
internal/license_reporting/license_reporting.go 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7215      +/-   ##
==========================================
- Coverage   52.72%   52.70%   -0.02%     
==========================================
  Files          89       89              
  Lines       20843    20843              
==========================================
- Hits        10989    10985       -4     
- Misses       9396     9398       +2     
- Partials      458      460       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 enabled auto-merge (squash) January 28, 2025 11:11
@pdabelf5 pdabelf5 merged commit 3dfb273 into main Jan 28, 2025
74 checks passed
@pdabelf5 pdabelf5 deleted the central-event-reasons branch January 28, 2025 13:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants