Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add hugo version check and theme update to Makefile #2608

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

nginx-jack
Copy link
Contributor

@nginx-jack nginx-jack commented Sep 26, 2024

Proposed changes

This should help prevent any hugo or hugo-theme version drift going forward, and warn when versions are out of date.

  • Add hugo version check and theme update to Makefile
  • Update README.md with correct make target behaviors
  • Add hugo-entrypoint to allow extra commands when docker starts
  • Update hugo theme version in go.mod
  • Use slimmer hugo docker image

Closes #2544

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Update README.md with correct make target behaviors
Add hugo-entrypoint to allow extra commands when docker starts
Update hugo theme version in go.mod
Use slimmer hugo docker image
@nginx-jack nginx-jack requested review from a team as code owners September 26, 2024 10:45
Copy link

nginx-bot bot commented Sep 26, 2024

Hi @nginx-jack!

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (1294e2d) to head (a6204fe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2608   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files         105      105           
  Lines        8116     8116           
  Branches       50       50           
=======================================
  Hits         7193     7193           
  Misses        866      866           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it works locally without hugo installed. Thanks @nginx-jack!

@ADubhlaoich ADubhlaoich enabled auto-merge (squash) October 2, 2024 13:27
@ADubhlaoich ADubhlaoich merged commit 605085a into nginx:main Oct 2, 2024
40 checks passed
nginx-jack added a commit to nginx-jack/nginx-gateway-fabric that referenced this pull request Oct 2, 2024
Update README.md with correct make target behaviors
Add hugo-entrypoint to allow extra commands when docker starts
Update hugo theme version in go.mod
Use slimmer hugo docker image
ADubhlaoich pushed a commit that referenced this pull request Oct 2, 2024
Update README.md with correct make target behaviors
Add hugo-entrypoint to allow extra commands when docker starts
Update hugo theme version in go.mod
Use slimmer hugo docker image
salonichf5 pushed a commit that referenced this pull request Oct 8, 2024
Update README.md with correct make target behaviors
Add hugo-entrypoint to allow extra commands when docker starts
Update hugo theme version in go.mod
Use slimmer hugo docker image
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Update README.md with correct make target behaviors
Add hugo-entrypoint to allow extra commands when docker starts
Update hugo theme version in go.mod
Use slimmer hugo docker image
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs Makefile commands don't work with hugo docker container
5 participants