Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix docs docker failing without git context #2654

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

nginx-jack
Copy link
Contributor

@nginx-jack nginx-jack commented Oct 7, 2024

Proposed changes

Fix docs docker failing without git context. Since adding LastMod, a proper git history is required during hugo build time. The mount point in docker doesn't pull in the .git directory, so it would always fail.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-jack nginx-jack requested review from a team as code owners October 7, 2024 14:33
@nginx-jack nginx-jack force-pushed the fix-docs-hugo-docker branch from 79c089a to 649e4b9 Compare October 7, 2024 14:37
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.66%. Comparing base (4d55abc) to head (7a4b1e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2654   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files         106      106           
  Lines        8141     8141           
  Branches       50       50           
=======================================
  Hits         7218     7218           
  Misses        866      866           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman merged commit 0b5ccc3 into nginx:main Oct 8, 2024
40 checks passed
nginx-jack added a commit to nginx-jack/nginx-gateway-fabric that referenced this pull request Oct 16, 2024
Add docker specific docs config to disable gitInfo
sjberman pushed a commit that referenced this pull request Oct 16, 2024
Fix docs docker failing without git context (#2654)

Add docker specific docs config to disable gitInfo
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Add docker specific docs config to disable gitInfo
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants