Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

NGINX Plus is inconsistently detected when deploying ingress controller helm chart #119

Closed
dekobon opened this issue Mar 24, 2022 · 0 comments
Closed

NGINX Plus is inconsistently detected when deploying ingress controller helm chart #119

dekobon opened this issue Mar 24, 2022 · 0 comments
Assignees
@dekobon
Labels
bug Something isn't working

Comments

@dekobon
Copy link
Collaborator

dekobon commented Mar 24, 2022

Describe the bug
Helm chart configuration enables plus functionality based on the image_tag or image_tag_alias containing the string plus. This logic is faulty because there may be images that are plus that do not contain that string.
@dekobon dekobon self-assigned this Mar 25, 2022
@dekobon dekobon added the bug Something isn't working label Mar 25, 2022
dekobon added a commit that referenced this issue Mar 25, 2022
@dekobon
fix(bug): fix #119 use configuration to enable NGINX Plus
7154ac3 
We relied on detecting the string 'plus' at the end of
the KIC image tag in order to determine if we would be
deploying KIC in Plus-enabled mode. This logic was
faulty, and it is best to replace it with an explicit
configuration option.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dekobon dekobon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dekobon