Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add a NS dependency in IC deployment #103

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

qdzlug
Copy link
Contributor

@qdzlug qdzlug commented Mar 1, 2022

Proposed changes

While doing testing, we noticed that there would be a transient warning during the IC deployment about the namespace not being ready. Checking into the code, we see that we don't have an explicit dependence on the namespace for the helm deployment. This usually is just annoying in that pulumi will retry, but on older or slower clusters this may lead to a timeout. This update fixes that hole.

Passes build/deploy in AWS, K3S, and MicroK8s.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@qdzlug qdzlug requested a review from dekobon March 1, 2022 01:52
@qdzlug qdzlug merged commit 4f26f59 into nginxinc:master Mar 1, 2022
@qdzlug qdzlug deleted the icfix branch March 1, 2022 16:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants