fix: add a NS dependency in IC deployment #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
While doing testing, we noticed that there would be a transient warning during the IC deployment about the namespace not being ready. Checking into the code, we see that we don't have an explicit dependence on the namespace for the helm deployment. This usually is just annoying in that pulumi will retry, but on older or slower clusters this may lead to a timeout. This update fixes that hole.
Passes build/deploy in AWS, K3S, and MicroK8s.
Checklist
Before creating a PR, run through this checklist and mark each as complete.