Add DigitalOcean Support #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 4, 2022 08:05
dekobon
approved these changes
Mar 8, 2022
| @@ -81,6 +81,11 @@ if pulumi config get kubernetes:infra_type -C ${script_dir}/../pulumi/python/con | |||
| sleep 5 | |||
| ${script_dir}/destroy_kube.sh | |||
| exit 0 | |||
| elif [ $INFRA == 'DO' ]; then | |||
There was a problem hiding this comment.
If we need per provider logic, it may be better to have a fixed path where we look for a script with a filename that includes an identifier. If the script exists, then we execute it. If we start to fork a lot of logical paths for each provider, we may quickly have a mess. Take this with a grain of salt.
| @@ -378,6 +385,11 @@ def add_namespace(obj): | |||
| pulumi.export('ipaddress', lb_ingress_ip) | |||
| #pulumi.export('application_url', f'https://{lb_ingress_hostname}') | |||
| application_url = sirius_host.apply(lambda host: f'https://{host}') | |||
| elif infra_type == 'DO': | |||
| pulumi.export('hostname', lb_ingress_hostname) | |||
| pulumi.export('ipaddress', lb_ingress_ip) | |||
There was a problem hiding this comment.
My mind desperately wants an underscore between ip and address.
There was a problem hiding this comment.
Mine too....but when I started digging I found out that it's "ipaddress" in all the library code so I decided to be consistent with the rest of the code.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds support for Digital Ocean, including the ability to stand up and tear down a K8 cluster as well as the additional logic required to deploy the monitoring/management resources and the Bank of Sirius application.
This change only works with the ingress-controller being deployed from the repo (NGINX or NGINX Plus). Full support for building the Ingress Controller, pushing to a private registry, etc will be implemented as part of #81. Full support for the IP/Hostname assigned by the K8 LoadBalancer object will continue to be managed by #82
Checklist
Before creating a PR, run through this checklist and mark each as complete.