Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: support NO_COLOR (#99) update jenkins slack calls #106

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

qdzlug
Copy link
Contributor

@qdzlug qdzlug commented Mar 9, 2022

Proposed changes

This change closes #99 by implementing the NO_COLOR variable for our start scripts which will allow the Jenkins output to be a bit cleaner without ANSI color codes.

This also removes the slackSend() calls from the Jenkinsfiles, as this is redundant when the Slack Global plugin is used.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@qdzlug qdzlug merged commit 7244220 into nginxinc:master Mar 9, 2022
@qdzlug qdzlug deleted the backlog branch March 9, 2022 23:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: allow environment variable to disable graphical banners
2 participants