Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(bug): fix #117 handle blank image_tag_alias #118

Merged
merged 2 commits into from
Mar 24, 2022
Merged

fix(bug): fix #117 handle blank image_tag_alias #118

merged 2 commits into from
Mar 24, 2022

Conversation

dekobon
Copy link
Collaborator

@dekobon dekobon commented Mar 24, 2022

When image_tag_alias is blank, a custom KIC image is not loaded because image_tag_alias may be present in repository_url but just a blank string. This change consolidates the logic into a single function and adds a check for a blank string.

Proposed changes

This PR fixes #117 and updates to the 1.3 tag for the Bank of Sirius app.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

dekobon added 2 commits March 24, 2022 09:06
When image_tag_alias is blank, a custom KIC image is not loaded
because image_tag_alias may be present in repository_url but
just a blank string. This change consolidates the logic into a single
function and adds a check for a blank string.
@dekobon dekobon marked this pull request as ready for review March 24, 2022 17:39
@dekobon dekobon requested a review from qdzlug March 24, 2022 17:39
Copy link
Contributor

@qdzlug qdzlug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dekobon dekobon merged commit 86c9c74 into master Mar 24, 2022
@dekobon dekobon deleted the issues/117 branch March 24, 2022 18:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ingress-controller deployment fails when it is passed an empty string for image_tag_alias
2 participants