Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: move .python-version file to the root, increase patch version #144

Merged
merged 1 commit into from
May 12, 2022

Conversation

4141done
Copy link
Contributor

@4141done 4141done commented May 10, 2022

Most version managers interpret the .python-version file from the root and apply the
python version specified to all child folders. Moving the .pythong-version file
to the root of the project ensures that the python version is the same for all
actions, but most importantly avoids a situation when running ./bin/setup_venv.sh
from the root where the system python will be hooked for the venv.

Proposed changes

  • Move .python-version file to root
  • Update python version to 3.9.12 as 3.9.6 fails to build on M1 macs. Happy to walk back this change if we think it's not a good enough reason to mess with the version required.

Example

$./bin/setup_venv.sh
# ...
$ source pulumi/python/venv/bin/activate
(venv) 
$ python --version
Python 3.9.12
(venv) 

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@4141done 4141done force-pushed the change-venv-location branch from c2509a6 to ff3deeb Compare May 10, 2022 17:44
Most version managers interpret the `.python-version` file from the root and apply the
python version specified to all child folders.  Moving the `.pythong-version` file
to the root of the project ensures that the python version is the same for all
actions, but most importantly avoids a situation when running `./bin/setup_venv.sh`
from the root where the system python will be hooked for the venv.
@4141done 4141done force-pushed the change-venv-location branch from ff3deeb to b3a2c10 Compare May 10, 2022 17:49
@qdzlug qdzlug merged commit 752f169 into nginxinc:master May 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants