Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: pip3 install now does not accept the --use-feature=in-tree-build #146

Merged
merged 1 commit into from
May 12, 2022

Conversation

4141done
Copy link
Contributor

@4141done 4141done commented May 12, 2022

The feature flag --use-feature=in-tree-build was introduced in pip 21.1 and then
the feature was mainlined in pip 21.3. With the flag in place pip install command
fails and kic_utils fails to build.

Based on the changelog which states that this behavior is default in pip 21.3+ and the current
build installs pip 22.1 we remove the flag.

fixes #145

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue
on GitHub, make sure to include a link to that issue here in this description
(not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

The feature flag `--use-feature=in-tree-build` was introduced in pip 21.1 and then
the feature was mainlined in pip 21.3.  With the flag in place `pip install` command
fails and `kic_utils` fails to build.

Based on the changelog which states that this behavior is default in pip 21.3+ and the current
build installs pip 22.1 we remove the flag.

fixes nginxinc#145
Copy link
Contributor

@qdzlug qdzlug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me; merging so we can verify.

@qdzlug qdzlug merged commit 2f60679 into nginxinc:master May 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: errors finding kic_util
2 participants