feat: add git url support to kic-image-build #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to specify git URLs in the kic:src_url configuration parameters. Additionally, it changes the behavior of the default operation when src_url is left unspecified to check out the KIC source directly from github using the latest tag instead of downloading a tar.gz archive from github.
qdzlug
approved these changes
Jul 12, 2021
| class IngressControllerSourceArchiveUrl: | ||
| LAST_KNOWN_KIC_VERSION = '1.11.3' | ||
| DOWNLOAD_URL = f'https://github.com/nginxinc/kubernetes-ingress/archive/refs/tags/|%|VERSION|%|.tar.gz' | ||
| LAST_KNOWN_KIC_VERSION = '1.12.0' |
There was a problem hiding this comment.
Should we move this into the configuration file for the overall project so it can be updated as the version for the KIC increments? Or perhaps follow the latest version here? (I'm not sure if that can be done easily.)
Previous to this change, when the latest KIC version could not be pulled from github, we would default to the latest known version. This functionality has been removed and we now just error.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds support to the kic:src_url configuration parameter for git URLs. Additionally, it changes the behavior of the default operation when src_url is left unspecified to check out the KIC source directly from github using the latest tag instead of downloading a tar.gz archive from github.
Checklist
Before creating a PR, run through this checklist and mark each as complete.