Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: update digital ocean token configuration variable and insert warning #210

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

qdzlug
Copy link
Contributor

@qdzlug qdzlug commented Nov 22, 2022

Proposed changes

This is a stop-gap measure to help with #208 - if the user has not specified the DIGITALOCEAN_TOKEN we will
warn them that it also needs to be in the environment.

Additional changes will make this a bit neater, but this will address it in the short term.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Copy link
Contributor

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. As always we have the caveat of the need for some more centralized specification for all of this config but as a bug fix this seems good. Some small suggestions and questions for my own learning but nothing blocking.

extras/jenkins/DigitalOcean/Jenkinsfile Show resolved Hide resolved
config/pulumi/Pulumi.stackname.yaml.example Show resolved Hide resolved
pulumi/python/automation/main.py Show resolved Hide resolved
@qdzlug qdzlug merged commit 4cef006 into nginxinc:master Nov 22, 2022
@qdzlug qdzlug deleted the doceanfix branch November 22, 2022 15:51
@qdzlug qdzlug mentioned this pull request Nov 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants