feat: add secret support to bank of anthos #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekobon
approved these changes
Jul 22, 2021
pulumi/aws/start_all.sh
Outdated
| # | ||
| if [ ! -f "${script_dir}/anthos/config/Pulumi.${PULUMI_STACK}.yaml" ]; then | ||
| echo "Merging master config with Bank of Anthos config" | ||
| yamlreader ${script_dir}/config/Pulumi.${PULUMI_STACK}.yaml ${script_dir}/anthos/config/Pulumi.stackname.yaml.example > \ |
There was a problem hiding this comment.
There is no assurance that we are in a virtual environment right now. Perhaps it may be best to reference the absolute path to yamlreader within the ${script_dir}/venv/bin path.
This was referenced Jul 24, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds secret support to the bank of anthos application. Because of limitations within Pulumi, a separate configuration file is used for the BOA secret management. The README.md file has been updated with the details of why this is, as well as the tooling that has been put into place to support this change. This will close issue #29
Checklist
Before creating a PR, run through this checklist and mark each as complete.