Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: warn with few AZs and separate subnet iteration #63

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

dekobon
Copy link
Collaborator

@dekobon dekobon commented Oct 26, 2021

Proposed changes

Pulumi will now log a warning when a VPC is created when there
are two or less availability zones available. Additionally, this
change breaks apart the logic for subnet iteration from the
list of availability zones in order to make increasing the
number of subnets easier.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Pulumi will now log a warning when a VPC is created when there
are two or less availability zones available. Additionally, this
change breaks apart the logic for subnet iteration from the
list of availability zones in order to make increasing the
number of subnets easier.
@dekobon dekobon requested a review from qdzlug October 26, 2021 22:48
Copy link
Contributor

@qdzlug qdzlug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - this is a helpful change.

@dekobon dekobon merged commit fe982e3 into master Oct 27, 2021
@dekobon dekobon deleted the verbose_subnets branch October 27, 2021 15:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants