Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: move to beta pulumi k8 sdk to migrate to helm releases #65

Merged
merged 13 commits into from
Nov 2, 2021

Conversation

qdzlug
Copy link
Contributor

@qdzlug qdzlug commented Oct 29, 2021

Proposed changes

Currently, MARA uses helm charts within pulumi. This approach works, but has some drawbacks as pulumi is not executing helm directly but instead is using the data in the helm chart to provision resources. The new (as of SDK 3.7+) release approach uses the helm SDK, which provides a great deal more flexibility.

This change cuts all the projects that use helm.chart over to helm.release, and adds some additional logging, error checking, and cleanup around the charts. We now lint the charts before we run them, and we rollback and cleanup any failures.

This has also changed the way we pull the hostname of the ELB; this logic may need to be adjusted for environments where a hostname is not provided and an IP is returned instead.

Testing is still underway; this change may require that we install helm3 in the venv, but that is yet to be determined.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@qdzlug qdzlug requested a review from dekobon October 29, 2021 15:15
@qdzlug qdzlug merged commit e07d7ea into nginxinc:master Nov 2, 2021
@qdzlug qdzlug deleted the helm-release branch November 2, 2021 15:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants