Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: address grafana config (#87) and aws/pulumi issues (#94) #95

Merged
merged 3 commits into from
Feb 16, 2022
Merged

fix: address grafana config (#87) and aws/pulumi issues (#94) #95

merged 3 commits into from
Feb 16, 2022

Conversation

qdzlug
Copy link
Contributor

@qdzlug qdzlug commented Feb 16, 2022

Proposed changes

This change closes two issues:

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@qdzlug qdzlug requested a review from dekobon February 16, 2022 15:49
@qdzlug qdzlug merged commit 2a3c319 into nginxinc:master Feb 16, 2022
@qdzlug qdzlug deleted the grafana-fix branch February 16, 2022 19:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dekobon dekobon dekobon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: issues with pulumi configuration and aws startup fix: remove deprecated grafana config options
2 participants
@qdzlug @dekobon