Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: replaced getJSON with transform.Unmarshal #87

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

  • Replaced getJSON with transform.Unmarshal in dimensions.html and metrics.html

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

Copy link
Collaborator

@nginx-jack nginx-jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be rendering the same as before 👍
Screenshot 2024-10-08 at 11 52 48

@lamATnginx lamATnginx merged commit 231e881 into main Oct 8, 2024
@ADubhlaoich ADubhlaoich deleted the unmarshal-data branch October 14, 2024 16:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants