Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(spectator): set input accepts alias names #652

Merged
merged 2 commits into from
Mar 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions projects/spectator/jest/test/set-input-alias-names.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import { Component, Input, input } from '@angular/core';
import { createComponentFactory } from '@ngneat/spectator/jest';

describe('SetInputAliasNames', () => {
describe('input decorators', () => {
@Component({
selector: 'app-root',
template: `
<div data-test="set-input--name">{{ name }}</div>
<div data-test="set-input--age">{{ numOfYears }}</div>
`,
standalone: true,
})
class DummyComponent {
@Input('userName') name!: string;
@Input({ alias: 'age' }) numOfYears!: number;
}

const createComponent = createComponentFactory(DummyComponent);

it('setInput should respect the alias names', () => {
// Arrange
const spectator = createComponent();

const nameElement = spectator.query('[data-test="set-input--name"]')!;
const ageElement = spectator.query('[data-test="set-input--age"]')!;

// Act
spectator.setInput('userName', 'John');
spectator.setInput('age', '123');

// Assert
expect(nameElement.innerHTML).toBe('John');
expect(ageElement.innerHTML).toBe('123');
});
});

describe('signal inputs', () => {
@Component({
selector: 'app-root',
template: `
<div data-test="set-input--name">{{ name() }}</div>
<div data-test="set-input--age">{{ numOfYears() }}</div>
`,
standalone: true,
})
class DummyComponent {
name = input.required({ alias: 'userName' });
numOfYears = input(0, { alias: 'age' });
}

const createComponent = createComponentFactory(DummyComponent);

it('setInput should respect the alias names', () => {
// Arrange
const spectator = createComponent({
detectChanges: false,
});

const nameElement = spectator.query('[data-test="set-input--name"]')!;
const ageElement = spectator.query('[data-test="set-input--age"]')!;

// Act
spectator.setInput('userName', 'John');
spectator.setInput('age', '123');

// Assert
expect(nameElement.innerHTML).toBe('John');
expect(ageElement.innerHTML).toBe('123');
});
});
});
9 changes: 5 additions & 4 deletions projects/spectator/src/lib/spectator/spectator.ts
Original file line number Diff line number Diff line change
@@ -42,6 +42,7 @@ export class Spectator<C> extends DomSpectator<C> {

public setInput<K extends keyof C>(input: InferInputSignals<C>): void;
public setInput<K extends keyof C>(input: K, inputValue: InferInputSignal<C[K]>): void;
public setInput(input: string, inputValue: unknown): void;
public setInput(input: any, value?: any): void {
setProps(this.fixture.componentRef, input, value);
// Force cd on the host component for cases such as: https://github.com/ngneat/spectator/issues/539
@@ -66,7 +67,7 @@ export class Spectator<C> extends DomSpectator<C> {
const renderedDeferFixture = await this._renderDeferStateAndGetFixture(
DeferBlockState.Complete,
deferBlockIndex,
deferBlockFixtures
deferBlockFixtures,
);

return this._childrenDeferFixtures(renderedDeferFixture);
@@ -75,7 +76,7 @@ export class Spectator<C> extends DomSpectator<C> {
const renderedDeferFixture = await this._renderDeferStateAndGetFixture(
DeferBlockState.Placeholder,
deferBlockIndex,
deferBlockFixtures
deferBlockFixtures,
);

return this._childrenDeferFixtures(renderedDeferFixture);
@@ -84,7 +85,7 @@ export class Spectator<C> extends DomSpectator<C> {
const renderedDeferFixture = await this._renderDeferStateAndGetFixture(
DeferBlockState.Loading,
deferBlockIndex,
deferBlockFixtures
deferBlockFixtures,
);

return this._childrenDeferFixtures(renderedDeferFixture);
@@ -108,7 +109,7 @@ export class Spectator<C> extends DomSpectator<C> {
private async _renderDeferStateAndGetFixture(
deferBlockState: DeferBlockState,
deferBlockIndex = 0,
deferBlockFixtures: Promise<DeferBlockFixture[]>
deferBlockFixtures: Promise<DeferBlockFixture[]>,
): Promise<DeferBlockFixture> {
const deferFixture = (await deferBlockFixtures)[deferBlockIndex];

72 changes: 72 additions & 0 deletions projects/spectator/test/set-input-alias-names.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import { Component, Input, input } from '@angular/core';
import { createComponentFactory } from '@ngneat/spectator';

describe('SetInputAliasNames', () => {
describe('input decorators', () => {
@Component({
selector: 'app-root',
template: `
<div data-test="set-input--name">{{ name }}</div>
<div data-test="set-input--age">{{ numOfYears }}</div>
`,
standalone: true,
})
class DummyComponent {
@Input('userName') name!: string;
@Input({ alias: 'age' }) numOfYears!: number;
}

const createComponent = createComponentFactory(DummyComponent);

it('setInput should respect the alias names', () => {
// Arrange
const spectator = createComponent();

const nameElement = spectator.query('[data-test="set-input--name"]')!;
const ageElement = spectator.query('[data-test="set-input--age"]')!;

// Act
spectator.setInput('userName', 'John');
spectator.setInput('age', '123');

// Assert
expect(nameElement.innerHTML).toBe('John');
expect(ageElement.innerHTML).toBe('123');
});
});

describe('signal inputs', () => {
@Component({
selector: 'app-root',
template: `
<div data-test="set-input--name">{{ name() }}</div>
<div data-test="set-input--age">{{ numOfYears() }}</div>
`,
standalone: true,
})
class DummyComponent {
name = input.required({ alias: 'userName' });
numOfYears = input(0, { alias: 'age' });
}

const createComponent = createComponentFactory(DummyComponent);

it('setInput should respect the alias names', () => {
// Arrange
const spectator = createComponent({
detectChanges: false,
});

const nameElement = spectator.query('[data-test="set-input--name"]')!;
const ageElement = spectator.query('[data-test="set-input--age"]')!;

// Act
spectator.setInput('userName', 'John');
spectator.setInput('age', '123');

// Assert
expect(nameElement.innerHTML).toBe('John');
expect(ageElement.innerHTML).toBe('123');
});
});
});
Loading