Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add host binding migration #528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add host binding migration #528

wants to merge 1 commit into from

Conversation

ostromeckyp
Copy link
Contributor

No description provided.

@ostromeckyp ostromeckyp mentioned this pull request Dec 2, 2024
Open
@ostromeckyp ostromeckyp force-pushed the feat/migrate-host-binding-to-host-in-decorator branch 2 times, most recently from be0b123 to 24f0916 Compare December 3, 2024 10:03
@ostromeckyp
Copy link
Contributor Author

@eneajaho kindly asking for a review

@eneajaho
Copy link
Collaborator

eneajaho commented Jan 2, 2025

@ostromeckyp This PR needs a rebase.

Also, just to let you know, we probably will get this merged in ngxtension, but I'm also working on a prototype that does the same thing, but working on getting it directly in the Angular repo, as that would make it easier for everyone to use.

But, because ngxtension already supports a lot of schematics, we can get this merged and out before I can get mine ready for the Angular one.

Thanks for creating this!

@ostromeckyp ostromeckyp force-pushed the feat/migrate-host-binding-to-host-in-decorator branch 3 times, most recently from d9896a0 to 05c43e3 Compare January 20, 2025 19:27
@ostromeckyp ostromeckyp force-pushed the feat/migrate-host-binding-to-host-in-decorator branch from 05c43e3 to 7854aa1 Compare January 30, 2025 09:12
@ostromeckyp
Copy link
Contributor Author

@eneajaho I am asking for a review after the changes :) - it would be beneficial as we started using ngxtension in our company and host migration would be helpful for our repo.

@eneajaho
Copy link
Collaborator

@eneajaho I am asking for a review after the changes :) - it would be beneficial as we started using ngxtension in our company and host migration would be helpful for our repo.

Hi @ostromeckyp
Can you rebase please? So then we can merge? Thanks

@ostromeckyp ostromeckyp force-pushed the feat/migrate-host-binding-to-host-in-decorator branch from 7854aa1 to d69d0f5 Compare February 12, 2025 07:41
@ostromeckyp
Copy link
Contributor Author

@eneajaho I am asking for a review after the changes :) - it would be beneficial as we started using ngxtension in our company and host migration would be helpful for our repo.

Hi @ostromeckyp Can you rebase please? So then we can merge? Thanks

Done

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eneajaho eneajaho eneajaho left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ostromeckyp @eneajaho