Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(ngx-control-value-accessor): accessing properties is outside of a reactive context #555

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix(ngx-control-value-accessor): accessing properties is outside of a reactive context #555

merged 1 commit into from
Feb 11, 2025

Conversation

RobbyRabbitman
Copy link
Contributor

fixes #547

@RobbyRabbitman RobbyRabbitman mentioned this pull request Feb 4, 2025
Open
eneajaho
eneajaho approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@eneajaho eneajaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eneajaho eneajaho merged commit 53c02f2 into ngxtension:main Feb 11, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eneajaho eneajaho eneajaho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decourage / remove option to access signal value in NgxControlValueAccessor via get value(){}
2 participants
@RobbyRabbitman @eneajaho