Fixes cascading orphan delete on versioned entity #3326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisitCollectionsBeforeSave must be called no matter if substitute is already true. On versioned entities this is always the case.
|
Looks like similar hibernate fix hibernate/hibernate-orm#3513 |
fredericDelaporte
changed the title
fredericDelaporte
added
t: Bug
c: Core
p: Minor
t: Fix
and removed
t: Bug
c: Core
p: Minor
labels
hazzik
previously approved these changes
Jul 12, 2023
There was a problem hiding this comment.
I've aligned tests to Hibernate and also applied @fredericDelaporte's suggestion
src/NHibernate.Test/Immutable/EntityWithMutableCollection/AbstractEntityWithManyToManyTest.cs
Show resolved
Hide resolved
bahusoid
previously approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Hibernate fix also uses optimization with additional isNewlyInstantiated check
default boolean isNewlyInstantiated() {
return getKey() == null && !isDirty();
}
It's wrong and breaks case when unwrapped collection is used for modifications. Adjusted test case to catch this case if someone decides to port this "optimization"
bahusoid
previously approved these changes
Jul 13, 2023
Shall we notify them? |
hazzik
reviewed
Jul 14, 2023
hazzik
changed the title
hazzik
approved these changes
Jul 14, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VisitCollectionsBeforeSave must be called no matter if substitute is already true. On versioned entities this is always the case.
Fixes #3325