Skip to content
This repository was archived by the owner on Oct 24, 2019. It is now read-only.

fix: exclude grid lifecycle event on bindEventHandlers #8

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Aug 8, 2019

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • exclude specific grid lifecycle event on bindEventHandlers
    • To prevent to register duplicated event, the event of starting with onGrid prefix is not registered through on method.

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link
Member

@jung-han jung-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료입니다~

Copy link

@dongwoo-kim dongwoo-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완료입니다~ 고생하셨어요 :)

@js87zz js87zz merged commit 9398e95 into master Aug 9, 2019
@js87zz js87zz deleted the feat/grid-lifecycle-event branch August 9, 2019 07:23
@js87zz js87zz changed the title feat: exclude grid lifecycle event on bindEventHandlers fix: exclude grid lifecycle event on bindEventHandlers Aug 9, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants