fix: always set ticket expires at as it can't be null #588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nhost/nhost#3035
PR Type
Bug fix
Description
TicketExpiresAt
field in multiple test cases to usesql.TimestampTz(time.Now())
ensuring it is always set to a non-null value.ticketExpiresAt
initialization in#UserWithouthSession
method to ensure it is always set to a non-null value.Changes walkthrough 📝
post_signin_idtoken_test.go
Set non-null `TicketExpiresAt` in test cases
go/controller/post_signin_idtoken_test.go
TicketExpiresAt
field to usesql.TimestampTz(time.Now())
instead of
pgtype.Timestamptz{}
.TicketExpiresAt
is always set to a non-null value in testcases.
workflows.go
Ensure `ticketExpiresAt` is non-null during user #
go/controller/workflows.go
ticketExpiresAt
initialization to usesql.TimestampTz(time.Now())
.ticketExpiresAt
is always set to a non-null value.