Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix express version at 3.17 and update ffmpeg code #36

Closed
wants to merge 3 commits into from
Closed

Fix express version at 3.17 and update ffmpeg code #36

wants to merge 3 commits into from

Conversation

schickm
Copy link
Contributor

@schickm schickm commented Sep 15, 2014

Bumping up to express 4 is a bit more complex than I'm qualified to do (longtime js programmer, first time node programmer). As discussed in #34, I set the express version 3.17, and I updated the ffmpeg code that reads the tags...now it's working again. The app should be functional again out of the box.

@nickdesaulniers
Copy link
Owner

Cool thanks Matt! To clean up this PR, can you git checkout config/config.json (maybe back up your customized version first). Then do a git rebase -I HEAD~3 (rebase the last 3 commits of yours), change the picks to squashs or just s edit commit message to just the first commit's, then git push -f (force push)? Or SourceTree or whatever preferred method. Also, I'm happy to see fluent changed their API to be error first in callbacks. Can you also update the version of fluent in the manifest?

Also, I can manually handle the rebasing if you prefer?

@schickm
Copy link
Contributor Author

schickm commented Sep 15, 2014

I’m sorry Nick, but I’m totally confused when it comes to rebasing etc…not really sure how to go about that. Thanks for the overview of the steps though. I’m gonna have to ask you to take care of it, because I was left floundering with git commands.

On Sep 15, 2014, at 2:14 PM, Nick Desaulniers notifications@github.com wrote:

Cool thanks Matt! To clean up this PR, can you git checkout config/config.json (maybe back up your customized version first). Then do a git rebase -I HEAD~3 (rebase the last 3 commits of yours), change the picks to squashs or just s edit commit message to just the first commit's, then git push -f (force push)? Or SourceTree or whatever preferred method. Also, I'm happy to see fluent changed their API to be error first in callbacks. Can you also update the version of fluent in the manifest?

Also, I can manually handle the rebasing if you prefer?


Reply to this email directly or view it on GitHub.

@nickdesaulniers
Copy link
Owner

It's ok, it's certainly overwhelming until you get it right (utter chaos when rebasing goes wrong though), and then becomes muscle memory. I've been meaning to write a blog post about this since I don't have a favorite reference I can just link people to.

@nickdesaulniers
Copy link
Owner

Thanks Matt, I merged this. Closing this PR.

@nickdesaulniers
Copy link
Owner

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants