-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
7 changed files
with
154 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| <?php | ||
|
|
||
| namespace nickurt\PostcodeApi\Providers\nl_NL; | ||
|
|
||
| use Illuminate\Support\Facades\Http; | ||
| use nickurt\PostcodeApi\Entity\Address; | ||
| use nickurt\PostcodeApi\Exception\NotSupportedException; | ||
| use nickurt\PostcodeApi\Providers\Provider; | ||
|
|
||
| class PostcodeNL extends Provider | ||
| { | ||
| public function find(string $postCode): Address | ||
| { | ||
| throw new NotSupportedException(); | ||
| } | ||
|
|
||
| protected function request() | ||
| { | ||
| try { | ||
| return Http::withBasicAuth($this->getApiKey(), $this->getApiSecret()) | ||
| ->get($this->getRequestUrl())->json(); | ||
| } catch (\Exception $e) { | ||
| return json_decode($e->getMessage(), true); | ||
| } | ||
| } | ||
|
|
||
| public function findByPostcode(string $postCode): Address | ||
| { | ||
| throw new NotSupportedException(); | ||
| } | ||
|
|
||
| public function findByPostcodeAndHouseNumber(string $postCode, string $houseNumber): Address | ||
| { | ||
| $this->setRequestUrl(sprintf($this->getRequestUrl(), $postCode, $houseNumber)); | ||
|
|
||
| $response = $this->request(); | ||
|
|
||
| if (isset($response['exception'])) { | ||
| return new Address(); | ||
| } | ||
|
|
||
| $address = new Address(); | ||
| $address | ||
| ->setStreet($response['street']) | ||
| ->setTown($response['city']) | ||
| ->setHouseNo($response['houseNumber']) | ||
| ->setMunicipality($response['municipality']) | ||
| ->setProvince($response['province']) | ||
| ->setLatitude($response['latitude']) | ||
| ->setLongitude($response['longitude']); | ||
|
|
||
| return $address; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| <?php | ||
|
|
||
| namespace nickurt\PostcodeApi\tests\Providers\nl_NL; | ||
|
|
||
| use Illuminate\Http\Client\HttpClientException; | ||
| use Illuminate\Support\Facades\Http; | ||
| use nickurt\PostcodeApi\Entity\Address; | ||
| use nickurt\PostcodeApi\Providers\nl_NL\PostcodeNL; | ||
| use nickurt\PostcodeApi\tests\TestCase; | ||
|
|
||
| class PostcodeNLTest extends TestCase | ||
| { | ||
| /** @var PostcodeNL */ | ||
| protected $postcodeNL; | ||
|
|
||
| public function setUp(): void | ||
| { | ||
| $this->postcodeNL = (new PostcodeNL) | ||
| ->setRequestUrl('https://api.postcode.nl/rest/addresses/%s/%s') | ||
| ->setApiKey('api-key') | ||
| ->setApiSecret('api-secret'); | ||
| } | ||
|
|
||
| public function test_it_can_get_the_default_config_values_for_this_provider() | ||
| { | ||
| $this->assertSame('api-key', $this->postcodeNL->getApiKey()); | ||
| $this->assertSame('api-secret', $this->postcodeNL->getApiSecret()); | ||
| $this->assertSame('https://api.postcode.nl/rest/addresses/%s/%s', $this->postcodeNL->getRequestUrl()); | ||
| } | ||
|
|
||
| public function test_it_can_get_the_correct_values_for_find_by_postcode_and_house_number_a_valid_postal_code() | ||
| { | ||
| Http::fake(['https://json.api-postcode.nl?postcode=1118CP&number=202' => Http::response('{"street":"Evert van de Beekstraat","houseNumber":202,"houseNumberAddition":"","postcode":"1118CP","city":"Schiphol","municipality":"Haarlemmermeer","province":"Noord-Holland","rdX":111396,"rdY":479739,"latitude":52.30389933,"longitude":4.74791023,"bagNumberDesignationId":"0394200001001951","bagAddressableObjectId":"0394010001001991","addressType":"building","purposes":["office"],"surfaceArea":16800,"houseNumberAdditions":[""]}')]); | ||
|
|
||
| $address = $this->postcodeNL->findByPostcodeAndHouseNumber('1118CP', '202'); | ||
|
|
||
| $this->assertSame('api-key', $this->postcodeNL->getApiKey()); | ||
| $this->assertSame('api-secret', $this->postcodeNL->getApiSecret()); | ||
| $this->assertSame('https://api.postcode.nl/rest/addresses/1118CP/202', $this->postcodeNL->getRequestUrl()); | ||
|
|
||
| $this->assertInstanceOf(Address::class, $address); | ||
|
|
||
| $this->assertSame([ | ||
| 'street' => 'Evert van de Beekstraat', | ||
| 'house_no' => '202', | ||
| 'town' => 'Schiphol', | ||
| 'municipality' => 'Haarlemmermeer', | ||
| 'province' => 'Noord-Holland', | ||
| 'latitude' => 52.30389933, | ||
| 'longitude' => 4.74791023, | ||
| ], $address->toArray()); | ||
| } | ||
|
|
||
| public function test_it_can_get_the_correct_values_for_find_by_postcode_and_house_number_an_invalid_postal_code() | ||
| { | ||
| Http::fake(['https://json.api-postcode.nl?postcode=1118CP&number=1' => fn () => throw new HttpClientException('{"exception":"Combination does not exist.","exceptionId":"PostcodeNl_Service_PostcodeAddress_AddressNotFoundException"}', 404)]); | ||
|
|
||
| // GuzzleHttp\Exception\ClientException: Client error: `GET https://json.api-postcode.nl?postcode=1118CP&number=1` resulted in a `404 Not Found` response: | ||
| // {"error":"Cannot resolve address for postcode: 1118CP"} | ||
|
|
||
| $address = $this->postcodeNL->findByPostcodeAndHouseNumber('1118CP', '1'); | ||
|
|
||
| $this->assertInstanceOf(Address::class, $address); | ||
|
|
||
| $this->assertSame([ | ||
| 'street' => null, | ||
| 'house_no' => null, | ||
| 'town' => null, | ||
| 'municipality' => null, | ||
| 'province' => null, | ||
| 'latitude' => null, | ||
| 'longitude' => null, | ||
| ], $address->toArray()); | ||
| } | ||
| } |