Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed mutliple bugs and BeatLeader compatibility. #159

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

Hermanest
Copy link
Contributor

@Hermanest Hermanest commented Jul 24, 2024

This PR

  • Fixes a problem of camera being subscribed to events even after destroy. The problem usually been happening in multiplayer.
  • Fixes compatibility with BeatLeader in FPFC mode with Camera2 (when replayer camera is not available).
  • Fixes compatibility with BeatLeader in just FPFC mode (when TrackedPoseDriver does not exist).

@Hermanest Hermanest changed the title Fixed events not being unsubscribed after camera destroy. Fixed mutliple bugs and BeatLeader compatibility. Jul 24, 2024
@nicoco007
Copy link
Owner

Thanks! I'll take a look at this as soon as I can.

@nicoco007
Copy link
Owner

Made some changes since the actual root cause is that it's subscribing the events twice when the game object is disabled during injection.

@nicoco007 nicoco007 merged commit 57a78d3 into nicoco007:main Jul 31, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants