Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactoring SQLite impemenation for OpenNRE #134

Closed
2 tasks done
Tracked by #131
nicolay-r opened this issue Dec 18, 2023 · 0 comments
Closed
2 tasks done
Tracked by #131

Refactoring SQLite impemenation for OpenNRE #134

nicolay-r opened this issue Dec 18, 2023 · 0 comments
Assignees
Labels
critical enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Dec 18, 2023

These parameters are both task and AREkit sampling schema specific:

# Task-related parameters.
self.no_label = "0"
self.default_id_column = "id"
self.index_columns = ["s_ind", "t_ind"]
self.text_columns = text_columns

This operation could be generalized and moved into separated file:

if self.text_columns is None:
cursor = self.conn.execute(f'select * from {self.table_name}')
column_names = list(map(lambda x: x[0], cursor.description))
self.text_columns = [col_name for col_name in column_names if col_name.startswith("text")]

  • SQlite3 as a separated 3-rd party service. (ade6cbe)
  • Move task-related parameters into the infer script. (10d98b3)
@nicolay-r nicolay-r added the enhancement New feature or request label Dec 18, 2023
@nicolay-r nicolay-r self-assigned this Dec 18, 2023
@nicolay-r nicolay-r mentioned this issue Dec 18, 2023
28 tasks
nicolay-r added a commit that referenced this issue Dec 23, 2023
…oring OpenNRE related class implementations (simplified)
nicolay-r added a commit that referenced this issue Dec 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
critical enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant