-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Updates to partition generation and object properties #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd changed code from Pyffi to be able to specify a body part order in the partition in update_skin_partition.
…in update_skin_partition). Partition order now based on vertex group order, and part flags are set automatically.
…f they are different than the defaults for the chosen game.
…ng exported name is not None
…ammatical error in documentation
…lues in the interface, and updated the docs accordingly.
neomonkeus
requested review from
neomonkeus and
HENDRIX-ZT2
and removed request for
neomonkeus
April 24, 2021 11:48
neomonkeus
added
Bug
Issue with specific functionality not working as intended but overall plugin is working.
Improvement
The issue improves on existing functionality
New Feature
A new feature not currently implemented
Usability
Improvement/impact to make the plugin easier to use
User Interface
Improve/impact how the user interacts with the plugin via Blender UI
labels
Apr 24, 2021
HENDRIX-ZT2
reviewed
Apr 24, 2021
@@ -327,11 +328,11 @@ def export_tri_shapes(self, b_obj, n_parent, trishape_name=None): | |||
v.r, v.g, v.b, v.a = vcollist[i] | |||
|
|||
if mesh_uv_layers: | |||
if bpy.context.scene.niftools_scene.game in ('FALLOUT_3', 'SKYRIM'): | |||
if len(mesh_uv_layers) > 1: | |||
raise NifError(bpy.context.scene.niftools_scene.game + " does not support multiple UV layers.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use fstring
io_scene_niftools/modules/nif_import/property/object/__init__.py
Outdated
Show resolved
Hide resolved
neomonkeus
reviewed
Apr 24, 2021
neomonkeus
reviewed
Apr 24, 2021
neomonkeus
reviewed
Apr 24, 2021
io_scene_niftools/modules/nif_export/property/object/__init__.py
Outdated
Show resolved
Hide resolved
neomonkeus
reviewed
Apr 24, 2021
io_scene_niftools/modules/nif_import/property/object/__init__.py
Outdated
Show resolved
Hide resolved
neomonkeus
reviewed
Apr 24, 2021
…in Prn export, as per PR review
HENDRIX-ZT2
approved these changes
Apr 25, 2021
neomonkeus
approved these changes
Apr 26, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Bug
Issue with specific functionality not working as intended but overall plugin is working.
Improvement
The issue improves on existing functionality
New Feature
A new feature not currently implemented
Usability
Improvement/impact to make the plugin easier to use
User Interface
Improve/impact how the user interacts with the plugin via Blender UI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@niftools/blender-niftools-addon-reviewer
Overview
Detailed Description
update_skin_partition
was copied from Pyffi. It has been updated to set the dismemberment flags correctly (previously used the wrong field name), and accepts an optional ordering of body part indices. If maximize_bone_sharing is true, it will keep the shared bone lists together, and order them by the first body part in the shared bone list. I think this is related to Dismember partition ordering on export #164 because of the title, but the issue itself doesn't have much information about what the actual problem is, so I'm not too sure.update_skin_partition
are used instead. The new sorting function is used to order the partitions by the order of their respective vertex groups.Prn
name (used to bind meshes to a bone without having to do weighting, as well as for weapon location), the number of different slots has been extended. The previous mapping was [slot]: value and was specific to Oblivion. It was also located in the import module, though it was used by both the import and export. The new mapping is [slot][game]: value. It is located in properties/object.py. It is formed from a list of lists, for easier editing. The mapping now also includes Fallout 3 and Skyrim.BS Num UV Set
property has been removed from object interface. It was already set automatically, and not used for import/export.Fixes Known Issues
Documentation
Testing
[Overview of testing required to ensure functionality is correctly implemented]
Manual
[Set of steps to manually verify updates are working correctly]
Automated
[List of tests run, updated or added to avoid future regressions]
Additional Information
[Anything else you deem relevant]