-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Release/v0.0.9 #461
Merged
Merged
Release/v0.0.9 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mesh (rather than the copy with tris).
…ed over update_tangent_space from pyffi and changed it so that vertices with same normals and position, but different UV coordinated no longer have the same tangents (because tangent calculation depends on UV coordinate)
…ating them separately.
… can't be, due to how the nif format works) when the normals weren't normalized, caused by Blender normalization being inconsistent.
…e only once per vertex, instead of first copying to all loops and then normalizing it independently multiple times.
…amed nr_vertices to num_vertices and renamed argument as_extra to as_extra_data.
…t in export/geometry/mesh. Pulled normalization of imported normals out to separate function. Use ndarray.asbytes() instead of struct.pack() for conversion to binary data.
…s, so that they will use title text without needing custim link text. Updated spelling of vertex colour to american for consistency.
…ported the way they are.
…Oblivion collision layers. No Skyrim functionality - best fix for that would be pyffi/nif.xml update.
…or when they forget to set the game.
… if file is not found, allowing re-export with working textures.
…created again if it already existed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@niftools/blender-niftools-addon-reviewer
Overview
[Overview of the content of the pull request]
Release v0.0.9
Detailed Description
[List of functional updates]
Export of normals now respects edges that are marked sharp.
Vertices with different UV coordinates get different tangents on export.
Export now uses Blender tangents instead of pyffi tangent generation.
Nif vertex normals are now imported correctly when dealing with non-normalized normals (i.e. not length 1).
When exporting a skinned mesh that uses partitions, that has faces without partitions, the correct faces are now selected.
The normal map Y channel is now inverted when creating a shader on import.
The selection for collision layer now depends on the game.
A NONE game as the default in the scene tab.
Unresolved texture paths are now stored as they are found in the nif file, meaning they remain functional upon re-export.
Body parts use face maps rather than vertex groups.
Fixes Known Issues
[Ordered list of issues fixed by this PR]
Documentation
[Overview of updates to documentation]
Testing
[Overview of testing required to ensure functionality is correctly implemented]
Manual
[Set of steps to manually verify updates are working correctly]
Automated
[List of tests run, updated or added to avoid future regressions]
Additional Information
[Anything else you deem relevant]