Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove trailing dots for descriptions and UI items - closes #246 #465

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

HENDRIX-ZT2
Copy link
Contributor

@niftools/blender-niftools-addon-reviewer

Overview

I think I've got them all.

Detailed Description

Trailing dots are no longer duplicated for UI strings.

Fixes Known Issues

closes #246

Documentation

[Overview of updates to documentation]

Testing

Not sure how to test it - starting from console no longer raises the warnings, at least for me.

Manual

[Set of steps to manually verify updates are working correctly]

Automated

[List of tests run, updated or added to avoid future regressions]

Additional Information

[Anything else you deem relevant]

@HENDRIX-ZT2 HENDRIX-ZT2 requested a review from Candoran2 October 4, 2021 16:08
@HENDRIX-ZT2 HENDRIX-ZT2 added Beginner Good issues for someone now familiar with the code or an easy fix User Interface Improve/impact how the user interacts with the plugin via Blender UI labels Oct 4, 2021
Copy link
Member

@Candoran2 Candoran2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you also removed the trailing dot on a number of EnumProperty items? I haven't been able to show the errors for myself, but I can see when there are two dots. Best I can tell, this is not the case for item descriptions. Or is it just to keep in line with Blender's formatting?

@HENDRIX-ZT2
Copy link
Contributor Author

Any reason you also removed the trailing dot on a number of EnumProperty items? I haven't been able to show the errors for myself, but I can see when there are two dots. Best I can tell, this is not the case for item descriptions. Or is it just to keep in line with Blender's formatting?

When I tested, they also showed two dots.

@Candoran2
Copy link
Member

Any reason you also removed the trailing dot on a number of EnumProperty items? I haven't been able to show the errors for myself, but I can see when there are two dots. Best I can tell, this is not the case for item descriptions. Or is it just to keep in line with Blender's formatting?

When I tested, they also showed two dots.

That's odd, they don't for me:
image
Anyways, it's probably best to keep with Blender's conventions regardless.

@HENDRIX-ZT2
Copy link
Contributor Author

grafik
They do for me on 2.93! 😅

@Candoran2
Copy link
Member

grafik They do for me on 2.93! 😅

Ah, I see the difference. It's when you hover over the option instead of hovering over the field. Yeah, I get two dots then as well.

@HENDRIX-ZT2 HENDRIX-ZT2 merged commit 06b9a7f into niftools:develop Oct 4, 2021
@neomonkeus neomonkeus mentioned this pull request Oct 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Beginner Good issues for someone now familiar with the code or an easy fix User Interface Improve/impact how the user interacts with the plugin via Blender UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants