Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added documentation for Install application from APK #31

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Added documentation for Install application from APK #31

merged 4 commits into from
Mar 6, 2024

Conversation

SanjayDevTech
Copy link
Contributor

For #20

@SanjayDevTech SanjayDevTech mentioned this pull request Feb 28, 2024
Open
5 tasks
garg3133
garg3133 reviewed Feb 29, 2024
View reviewed changes
Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format looks good overall. Suggested a few changes.

docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
docs/Installing-an-application-from-APK.md Outdated Show resolved Hide resolved
@garg3133 garg3133 mentioned this pull request Feb 29, 2024
Open
@SanjayDevTech SanjayDevTech requested a review from garg3133 March 1, 2024 03:09
@SanjayDevTech
Copy link
Contributor Author

Tagging you @garg3133 , in case if you didn't received the notification for Review request.
I have made the requested changes kindly have a look. Thanks

@garg3133
Copy link
Member

garg3133 commented Mar 6, 2024

This looks really good! Thanks a lot @SanjayDevTech for this PR, and sorry for the delay in reviewing it.

Added a few changes myself, mostly to the ADB section, to make it more clear.

Thanks again!

@garg3133 garg3133 merged commit b4349cd into nightwatchjs:main Mar 6, 2024
2 checks passed
@SanjayDevTech
Copy link
Contributor Author

Thanks @garg3133

@SanjayDevTech SanjayDevTech deleted the sanjaydevtech/docs/adb-install-apk branch March 28, 2024 04:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@garg3133 garg3133 Awaiting requested review from garg3133

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanjayDevTech @garg3133