Fix queue resolution without error in between test case. #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status
|
garg3133
commented
Jan 15, 2025
| @@ -127,7 +127,13 @@ class CommandQueue extends EventEmitter { | |||
|
|
|||
| err = err || this.tree.returnError; | |||
|
|
|||
| // only used in hooks | |||
| this.emit('queue:finished', err); | |||
There was a problem hiding this comment.
This was required to be executed before checking if the currentResult is resolved because some hooks are only resolved after the queue:finished event is fired and not firing it before the below condition was resulting in a deadlock where the currentResult won't be settled until the hooks are resolved and the hooks won't be resolved until the currentResult is settled and the queue:finished event is fired after it.
|
Closing this because we found a better solution in #4325 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.