-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add --no-outer-gaps
to the fullscreen
command
#472
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitabobko
requested changes
Aug 31, 2024
thanks for the suggestions, I fixed all of them |
nikitabobko
reviewed
Sep 1, 2024
d63e42d
to
296d7ce
Compare
Thanks! Merged with the following patch: diff --git a/Sources/AppBundle/command/FullscreenCommand.swift b/Sources/AppBundle/command/FullscreenCommand.swift
index 6a758b9b..71b70bab 100644
--- a/Sources/AppBundle/command/FullscreenCommand.swift
+++ b/Sources/AppBundle/command/FullscreenCommand.swift
@@ -14,7 +14,7 @@ struct FullscreenCommand: Command {
case .off: false
case .toggle: !window.isFullscreen
}
- if newState == window.isFullscreen && args.noOuterGaps == window.noOuterGapsInFullscreen {
+ if newState == window.isFullscreen {
return state.failCmd(msg: newState ? "Already fullscreen" : "Already not fullscreen")
}
window.isFullscreen = newState
diff --git a/Sources/Common/cmdArgs/FullscreenCmdArgs.swift b/Sources/Common/cmdArgs/FullscreenCmdArgs.swift
index f865691a..119fee05 100644
--- a/Sources/Common/cmdArgs/FullscreenCmdArgs.swift
+++ b/Sources/Common/cmdArgs/FullscreenCmdArgs.swift
@@ -28,5 +28,5 @@ public struct FullscreenCmdArgs: CmdArgs, RawCmdArgs {
public func parseFullscreenCmdArgs(_ args: [String]) -> ParsedCmd<FullscreenCmdArgs> {
return parseRawCmdArgs(FullscreenCmdArgs(rawArgs: args), args)
- .filter("--no-outer-gaps is incompatible with node off") { $0.toggle != .off || $0.noOuterGaps != true }
+ .filter("--no-outer-gaps is incompatible with 'off' argument") { $0.toggle != .off || $0.noOuterGaps != true }
}
diff --git a/docs/aerospace-fullscreen.adoc b/docs/aerospace-fullscreen.adoc
index 33beda8d..54857b14 100644
--- a/docs/aerospace-fullscreen.adoc
+++ b/docs/aerospace-fullscreen.adoc
@@ -7,9 +7,12 @@ include::util/man-attributes.adoc[]
// =========================================================== Synopsis
== Synopsis
+
+[verse]
// tag::synopsis[]
aerospace fullscreen [-h|--help] [--no-outer-gaps] [on]
aerospace fullscreen [-h|--help] off
+
// end::synopsis[]
// =========================================================== Description
|
badprince71
added a commit
to badprince71/AeroSpace
that referenced
this pull request
Mar 9, 2025
closes nikitabobko/AeroSpace#472 Co-authored-by: Nikita Bobko <git@bobko.xyz>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #373