Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add --no-outer-gaps to the fullscreen command #472

Closed
wants to merge 3 commits into from

Conversation

vrumger
Copy link
Contributor

@vrumger vrumger commented Aug 30, 2024

Closes #373

@vrumger
Copy link
Contributor Author

vrumger commented Sep 1, 2024

thanks for the suggestions, I fixed all of them

@vrumger vrumger force-pushed the fullscreen-no-outer-gaps branch from d63e42d to 296d7ce Compare September 1, 2024 12:07
@nikitabobko
Copy link
Owner

Thanks!

Merged with the following patch:

diff --git a/Sources/AppBundle/command/FullscreenCommand.swift b/Sources/AppBundle/command/FullscreenCommand.swift
index 6a758b9b..71b70bab 100644
--- a/Sources/AppBundle/command/FullscreenCommand.swift
+++ b/Sources/AppBundle/command/FullscreenCommand.swift
@@ -14,7 +14,7 @@ struct FullscreenCommand: Command {
             case .off: false
             case .toggle: !window.isFullscreen
         }
-        if newState == window.isFullscreen && args.noOuterGaps == window.noOuterGapsInFullscreen {
+        if newState == window.isFullscreen {
             return state.failCmd(msg: newState ? "Already fullscreen" : "Already not fullscreen")
         }
         window.isFullscreen = newState
diff --git a/Sources/Common/cmdArgs/FullscreenCmdArgs.swift b/Sources/Common/cmdArgs/FullscreenCmdArgs.swift
index f865691a..119fee05 100644
--- a/Sources/Common/cmdArgs/FullscreenCmdArgs.swift
+++ b/Sources/Common/cmdArgs/FullscreenCmdArgs.swift
@@ -28,5 +28,5 @@ public struct FullscreenCmdArgs: CmdArgs, RawCmdArgs {
 
 public func parseFullscreenCmdArgs(_ args: [String]) -> ParsedCmd<FullscreenCmdArgs> {
     return parseRawCmdArgs(FullscreenCmdArgs(rawArgs: args), args)
-        .filter("--no-outer-gaps is incompatible with node off") { $0.toggle != .off || $0.noOuterGaps != true }
+        .filter("--no-outer-gaps is incompatible with 'off' argument") { $0.toggle != .off || $0.noOuterGaps != true }
 }
diff --git a/docs/aerospace-fullscreen.adoc b/docs/aerospace-fullscreen.adoc
index 33beda8d..54857b14 100644
--- a/docs/aerospace-fullscreen.adoc
+++ b/docs/aerospace-fullscreen.adoc
@@ -7,9 +7,12 @@ include::util/man-attributes.adoc[]
 
 // =========================================================== Synopsis
 == Synopsis
+
+[verse]
 // tag::synopsis[]
 aerospace fullscreen [-h|--help] [--no-outer-gaps] [on]
 aerospace fullscreen [-h|--help] off
+
 // end::synopsis[]
 
 // =========================================================== Description

@nikitabobko nikitabobko added the pr-accepted Pull Request is accepted label Sep 1, 2024
badprince71 added a commit to badprince71/AeroSpace that referenced this pull request Mar 9, 2025
closes nikitabobko/AeroSpace#472

Co-authored-by: Nikita Bobko <git@bobko.xyz>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pr-accepted Pull Request is accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement fullscreen --no-outer-gaps
2 participants