Generalize content processing with markdown as default (implements #4) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rked as default processor for *.md files (compat behaviour). Implements nikku#4. Processors can be defined in the configuration as follows: ``` { contentProcessors: { '*.md': function(content, page) { return marked(content); }, '*': function(content, page) { return emoji(content); }, } } ``` Object keys are globs matched against the page's id (i.e., including relative path) using minimatch with the options `{ nocase: true, matchBase: true }`. Processor order is preserved, such that multiple matching processors are applied in the order defined. Also adds tests for non-markdown file processing and aggregation based off the example structure. Finally, the method `Kartoffeldruck.isMarkdown` is removed from the +public+ API.
|
Merged via f89d412. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple content processors using marked as default processor for *.md files (compat behaviour). Implements #4.
Processors can be defined in the configuration as follows:
Object keys are globs matched against the page's id (i.e., including relative path) using minimatch with the options
{ nocase: true, matchBase: true }. Processor order is preserved, such that multiple matching processors are applied in the order defined.Also adds tests for non-markdown file processing and aggregation based off the example structure.
Finally, the method
Kartoffeldruck.isMarkdownis removed from the +public+ API.