Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement RangedNode to keep the position of the node #92

Closed
wants to merge 1 commit into from

Conversation

M3kH
Copy link

@M3kH M3kH commented Nov 14, 2022

This is still a work in progress to understand desired direction.

Implements Options 4 of the Issue #91 by adding RangedNode to the library.

A desire state might be replace Node definition with the the one of RangedNode and align more with LSP defition:

struct Range {
  Start { Line int, Char int }
  End { Line int, Char int }
}

Todo

  • Define Schema
  • Fix wrong line number in inline nodes
  • Write test

@niklasfasching
Copy link
Owner

#91 (comment)

Since this seems stuck, I'm gonna close it for now. Feel free to re-open when you start looking into this again :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants