Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

isolate_readline_context() don't isolates readline history #54

Closed
nil0x42 opened this issue Jan 9, 2019 · 1 comment
Closed

isolate_readline_context() don't isolates readline history #54

nil0x42 opened this issue Jan 9, 2019 · 1 comment
Labels
bug
Milestone
Release 3.1

Comments

@nil0x42
Copy link
Owner

nil0x42 commented Jan 9, 2019

Steps to reproduce:

  • run phpsploit
  • run commands to have a basic history
  • run corectl python-console (without bpython/ipython)
  • press UP arrow key, history is not reset

Notes:

isolate_readline_context & isolate_io_context decorators should backup a copy of the history, flush it, run the decorated function, and finally flush temp history and restore the previous one.
@nil0x42 nil0x42 added the bug label Jan 9, 2019
nil0x42 added a commit that referenced this issue Jan 11, 2019
@nil0x42
Fix issue #54
e6f60f9 
`isolate_io_context()` and `isolate_readline_context()` decorators
now properly isolate readline's history.
@nil0x42
Copy link
Owner Author

nil0x42 commented Jan 11, 2019

Resolved by e6f60f9

@nil0x42 nil0x42 closed this as completed Jan 11, 2019
@nil0x42 nil0x42 changed the title isolate_readline_context doesn't isolate readline history context isolate_readline_context() don't isolates readline history Jan 15, 2019
@nil0x42 nil0x42 added this to the Release 3.1 milestone Jan 15, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Release 3.1
Development

No branches or pull requests
1 participant
@nil0x42