Wip #87
Merged
Wip #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `grep checker` on phpsploit_pipe() could think command output was terminated, while some lines were still missing to get return code.
- implement functional tests @ test/core/core.plugins/
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 58.81% 58.81%
=======================================
Files 69 69
Lines 3249 3249
Branches 607 607
=======================================
Hits 1911 1911
Misses 1139 1139
Partials 199 199 |
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 58.34% 58.81% +0.47%
==========================================
Files 69 69
Lines 3212 3249 +37
Branches 606 607 +1
==========================================
+ Hits 1874 1911 +37
Misses 1139 1139
Partials 199 199 |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
src/ui/output/wrapper.py
Outdated
| @@ -178,7 +178,7 @@ def process_tags(line): | |||
| line = colorize(*tag) + line[len(tag[1]):] | |||
|
|
|||
| # colorize «*» patterns from tagged line: | |||
| dye = lambda obj: colorize('%White', "« " + obj.group(1) + " »") | |||
| dye = lambda obj: colorize('%White', repr(obj.group(1))) | |||
There was a problem hiding this comment.
Do not assign a lambda expression, use a def
src/core/plugins/Plugin.py
Outdated
| @@ -31,12 +31,14 @@ def __init__(self, path): | |||
| path = path[:-1] | |||
| self.path = path | |||
| self.name = os.path.basename(path) | |||
| self.argv = [] # redefined at runtime on run() | |||
There was a problem hiding this comment.
At least two spaces before inline comment
src/core/session/environment.py
Outdated
| return re.match("^[A-Z][A-Z0-9_]+$", name) | ||
|
|
||
| def update(self, dic): | ||
| def update(self, new_dict): |
There was a problem hiding this comment.
Cyclomatic complexity is too high in method update. (8)
make it more resilient by testing different timeouts
|
Code Climate has analyzed commit b3e31a9 and detected 147 issues on this pull request. Here's the issue category breakdown:
Note: there are 14 critical issues. View more on Code Climate. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.