remove jstin from important packages #17765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #17759 https://github.com/LemonBoy/jstin/blob/master/src/jstin.nim is already archived and cannot pass CI anymore.
|
How about putting the source code and tests to Nim repo? I remember the code caught a regression ever. |
If you feel like it. |
let's fork it instead, eg under nim-lang/nim, and change nimble url to point to the new fork |
|
please do it, i don't have the right. |
|
done => https://github.com/nim-lang/jstin
@Araq how about giving @xflywind those rights? there were a few other instances like that TODO:
|
timotheecour
added
the
TODO: followup needed
This was referenced Apr 25, 2021
ringabout
removed
the
TODO: followup needed
ringabout
added a commit
that referenced
this pull request
Apr 25, 2021
timotheecour
pushed a commit
that referenced
this pull request
Apr 25, 2021
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
Ref nim-lang#17759 https://github.com/LemonBoy/jstin/blob/master/src/jstin.nim is already archived and cannot pass CI anymore.
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #17759
Ref #17711
https://github.com/LemonBoy/jstin/blob/master/src/jstin.nim is already archived and cannot pass CI anymore.