New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Convert utf8 column position to utf16 #264

Merged

jmgomez merged 3 commits into nim-lang:master from doongjohn:master

Nov 30, 2024

Contributor

doongjohn commented Nov 30, 2024

fixes: Unicode Variable Name Support Issue in Nim VS Code Extension #242
fixes: toDiagnostic range
Change toLabelRange to include `
Added hover range info

doongjohn added 2 commits

November 30, 2024 13:20


          Convert utf8 columns to utf16

8cfc09d


          Update hover to send the range info

c4a88c0

Collaborator

jmgomez commented Nov 30, 2024

Thanks for the PR @doongjohn ! But please add some tests


          Update tests to check utf16 position

b770835

jmgomez merged commit cf85884 into nim-lang:master

1 check passed

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet