Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use current directory if none is supplied in InitializeParams #82

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

GeneTinderholm
Copy link
Contributor

@GeneTinderholm GeneTinderholm commented Dec 24, 2023

I was just starting to play around with nim (seems like a cool language).

The language server was dying when trying to run with nvim, which made going through some examples from the docs and playing around with the code kinda rough. When working on the local version of the language server, it did work however, which was weird.

I did some spelunking and it looks like the rootUri field of InitializeParams is empty sometimes? I'm not super knowledgeable about language servers. Potentially this is because it doesn't detect any sort of nimble setup in the directory?

This change made most functionality work on my end, mostly auto-complete and hover, and doesn't seem like it would break things for anyone else.

@nazgulsenpai
Copy link

nimlangserver didn't work in helix editor for me ('nimlangserver has exited' immediately), so did nimble install https://github.com/GeneTinderholm/nimlangserver and this PR fixed it for me. Thank you and hopefully this gets merged.

@jmgomez jmgomez merged commit 2e0427e into nim-lang:master Dec 28, 2023
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants