Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unsubscribe streams #37

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Unsubscribe streams #37

merged 1 commit into from
Jan 27, 2025

Conversation

Eligioo
Copy link
Member

@Eligioo Eligioo commented Jan 21, 2025

By adding a specialised unsubscribe request handler that lets the server terminates specific streams.

This PR is build on top of stefan/axum (#36).

Fixes nimiq/core-rs-albatross#3216

@Eligioo Eligioo requested review from jsdanielh and hrxi January 21, 2025 10:33
@Eligioo Eligioo changed the base branch from master to stefan/axum January 21, 2025 10:38
@Eligioo Eligioo force-pushed the stefan/unsubscribe-stream branch from 1514975 to 52a472e Compare January 21, 2025 10:41
@Eligioo Eligioo changed the title Stefan/unsubscribe stream Unsubscribe streams Jan 21, 2025
@Eligioo Eligioo force-pushed the stefan/unsubscribe-stream branch from 52a472e to f572d6a Compare January 21, 2025 12:02
@Eligioo Eligioo force-pushed the stefan/unsubscribe-stream branch from f572d6a to b592346 Compare January 22, 2025 08:15
Base automatically changed from stefan/axum to master January 22, 2025 22:11
server/src/lib.rs Outdated Show resolved Hide resolved
server/src/lib.rs Outdated Show resolved Hide resolved
server/src/lib.rs Outdated Show resolved Hide resolved
@Eligioo Eligioo force-pushed the stefan/unsubscribe-stream branch from b592346 to aceff0f Compare January 27, 2025 08:42
Copy link
Member

@jsdanielh jsdanielh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

By adding a specialized unsubsribe request handler that lets the server terminates specifc streams
@jsdanielh jsdanielh force-pushed the stefan/unsubscribe-stream branch from aceff0f to d0439d1 Compare January 27, 2025 21:40
@jsdanielh jsdanielh merged commit d0439d1 into master Jan 27, 2025
7 checks passed
@jsdanielh jsdanielh deleted the stefan/unsubscribe-stream branch January 27, 2025 21:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Unsubscribe Methods for WebSocket Streams in JSON-RPC
2 participants