Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

SIGFPE on system with zero in /cgroup/cpu/cpu.cfs_period_us #2173

Closed
lrtfm opened this issue Jul 28, 2022 · 1 comment
Closed

SIGFPE on system with zero in /cgroup/cpu/cpu.cfs_period_us #2173

lrtfm opened this issue Jul 28, 2022 · 1 comment
Labels
bug
Milestone
1.11.1

Comments

@lrtfm
Copy link
Contributor

lrtfm commented Jul 28, 2022 •
edited
Loading

In the code, to calculate the cpu limit, if the value of /cgroup/cpu/cpu.cfs_period_us is 0, the program will generate the signal SIGFPE. Should we protect this by checking the value of period.first?

code:

ninja/src/util.cc

Line 650 in d4017a2

return quota.first / period.first;

The error information:

Program received signal SIGFPE, Arithmetic exception.
0x000000000042d2d5 in ParseCPUFromCGroup() () at ./src/util.cc:650
650       return quota.first / period.first;
@lrtfm lrtfm mentioned this issue Jul 28, 2022
Merged
@jhasse jhasse added this to the 1.11.1 milestone Aug 23, 2022
@jhasse jhasse added the bug label Aug 23, 2022
@jhasse jhasse closed this as completed Aug 23, 2022
jhasse pushed a commit that referenced this issue Aug 30, 2022
@lrtfm @jhasse
Fixbug: SIGFPE error when cpu.cfs_period_us = 0
d502d19 
This will fix the issue (#2173).
bradking pushed a commit to bradking/ninja that referenced this issue Oct 6, 2022
@lrtfm @bradking
Fixbug: SIGFPE error when cpu.cfs_period_us = 0
cac1772 
This will fix the issue (ninja-build#2173).
PolynomialDivision pushed a commit to PolynomialDivision/ninja that referenced this issue Nov 3, 2022
@lrtfm @PolynomialDivision
Fixbug: SIGFPE error when cpu.cfs_period_us = 0
a46e207 
This will fix the issue (ninja-build#2173).
@AyandaRevon
Copy link

*123

johanneslerch pushed a commit to johanneslerch/ninja that referenced this issue Jun 2, 2023
@lrtfm
Fixbug: SIGFPE error when cpu.cfs_period_us = 0
0dd96e9 
This will fix the issue (ninja-build#2173).

(cherry picked from commit d502d19)
johanneslerch pushed a commit to johanneslerch/ninja that referenced this issue Jun 2, 2023
@lrtfm
Fixbug: SIGFPE error when cpu.cfs_period_us = 0
2d552ce 
This will fix the issue (ninja-build#2173).

(cherry picked from commit d502d19)
@honeway honeway mentioned this issue Oct 13, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.11.1
Development

No branches or pull requests
5 participants
@jhasse @lrtfm @AyandaRevon and others