Migrate to c++14 #2560
Merged
Migrate to c++14 #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11 with c++14 when building tests as we are now targeting the min required version
|
@jhasse I noticed that we are getting CI failures on ARM64. The seg fault makes me wonder if it is a problem with the image... has this been a problem in the past? |
|
See #2554 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #2531
Before we can bring in the latest version of hash_table8 we need to migrate to c++14. This should also bring some quality of life to future development as developers will have access to
std::make_unique. There weren't any major deprecations in c++14 so we shouldn't see any warnings there if we ever happen to remove-Wno-deprecated.What changed
Updated configure.py to...